Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert one change from #4844 #5186

Merged
merged 1 commit into from Apr 14, 2020

Conversation

hamish-milne
Copy link
Contributor

@hamish-milne hamish-milne commented Apr 7, 2020

This fixes #5067 by reverting a speculative change made in a previous PR.

From this one can conclude that, for disabled textures, black (0,0,0,1) is the correct colour and clear (0,0,0,0) is not.


This change is Reviewable

This fixes citra-emu#5067 by reverting a speculative change made in a previous PR.

From this one can conclude that, for disabled textures, black (0,0,0,1) is the correct colour and clear (0,0,0,0) is not.
@BreadFish64
Copy link
Contributor

BreadFish64 commented Apr 8, 2020

So, if I understand, this is still not the correct behavior, but this is less likely to cause problems?

@B3n30
Copy link
Contributor

B3n30 commented Apr 8, 2020

will this cause #2133 again?

@hamish-milne
Copy link
Contributor Author

hamish-milne commented Apr 8, 2020

@BreadFish64 I've no idea what the correct behaviour is tbh. But it's probably less incorrect than before.
@B3n30 No, that relates to 'null' textures which are unchanged. This relates to disabled textures.

@MarcoEstevez
Copy link

MarcoEstevez commented Apr 8, 2020

Can confirm #5067 got fixed

@BreadFish64 BreadFish64 merged commit 45dfb3a into citra-emu:master Apr 14, 2020
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants