Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Luigi's Mansion can't remove amiibo bug #5200

Merged
merged 2 commits into from Apr 14, 2020
Merged

Fix Luigi's Mansion can't remove amiibo bug #5200

merged 2 commits into from Apr 14, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 12, 2020

It happened because SyncTagState was doing nothing.
Doesn't break any games.


This change is Reviewable

@wwylele
Copy link
Member

wwylele commented Apr 12, 2020

If I understand correctly, the code change is basically a "yes" answer to the TODO I left there. I want to know if this is thoroughly hardware tested, or a guess work based on game behavior. I am fine with the change as long as

  • attach the hardware test program if you did it, or
  • keep the TODO there (maybe rephrasing it a little bit) so that it is still an open question that people can later test more.

For other reviewers: see #4893 for the context

@ghost
Copy link
Author

ghost commented Apr 12, 2020

guess work

B3n30
B3n30 approved these changes Apr 14, 2020
@B3n30 B3n30 merged commit 263e5be into citra-emu:master Apr 14, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants