Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video_core: add ScaleForce to texture filters #5210

Merged
merged 3 commits into from Apr 16, 2020

Conversation

BreadFish64
Copy link
Contributor

@BreadFish64 BreadFish64 commented Apr 14, 2020

This one is my own invention.
https://github.com/BreadFish64/ScaleFish/tree/master/scale_force
The idea is similar to Anime4K in that it detects short gradients and pushes the color values toward one side or the other; however, ScaleForce is a single pass shader, and produces much better all-around results in my testing.
example: https://youtu.be/njCOsH062vE


This change is Reviewable


#include "video_core/renderer_opengl/gl_rasterizer_cache.h"
#include "video_core/renderer_opengl/texture_filters/scale_force/scale_force.h"

Copy link

@ghost ghost Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Contributor Author

@BreadFish64 BreadFish64 Apr 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd prefer to keep shader files separate in the includes.

Co-Authored-By: Valentin Vanelslande <vvanelslandedev@gmail.com>
@B3n30
Copy link
Contributor

B3n30 commented Apr 14, 2020

I'm a bit confused about the copyrighting. Which part of it is copyrighted by you? Only the cpp file?

Would it be possible to add this code as a submodule so keeping track with the cahnges in your repo would be easier?

@BreadFish64
Copy link
Contributor Author

BreadFish64 commented Apr 14, 2020

I put the copyright in the C++ files to keep it consistent with the other filters although that maybe isn't the best place for it. Only the shader is copyrighted by me.
As for submoduling, I don't think that would be a great idea. The original shader is written for OpenGL 4.5 and contains extra code for outputting intermediate computation results.

@B3n30
Copy link
Contributor

B3n30 commented Apr 14, 2020

Can the copyright notice then be a comment in the shader file?

The original shader is written for OpenGL 4.5 and contains extra code for outputting intermediate computation results. I think it would also be worth noting this as a comment in the shader

@BreadFish64
Copy link
Contributor Author

BreadFish64 commented Apr 14, 2020

Can do 👍

Here's some still-image results.
Smash Bros Logo ScaleForce
Health   Safety ScaleForce

@BreadFish64 BreadFish64 merged commit 55ecaa0 into citra-emu:master Apr 16, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants