Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MIC_U serialization and timing #5223

Merged
merged 4 commits into from Apr 18, 2020

Conversation

hamish-milne
Copy link
Contributor

@hamish-milne hamish-milne commented Apr 17, 2020

This fixes a conversion error that causes mic update events to be run far more frequently than intended, causing massive slowdowns in some games. After fixing, I experienced a 5x speedup in The Sims 3.

Prior to this PR, the speedup could be achieved by using a savestate. This was due to a bug that unscheduled the mic update event when loading, which this PR fixes.


This change is Reviewable

Subv
Subv approved these changes Apr 17, 2020
src/core/hle/service/mic_u.cpp Outdated Show resolved Hide resolved
@B3n30
Copy link
Contributor

B3n30 commented Apr 18, 2020

fixes #5209

@B3n30 B3n30 merged commit 397bd1b into citra-emu:master Apr 18, 2020
2 of 3 checks passed
@Dragios
Copy link
Contributor

Dragios commented Apr 19, 2020

It used to be The Sims 3/Pets is slower with New 3DS mode enabled. With Save State PR combined it cause even more slow down. This is no longer the case as it is totally fixed with this PR. New or Old 3DS mode makes no performance difference now.
Just leave a note here for future reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants