Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

savedata_archive: Make GetFreeBytes return a more accurate value #5282

Merged
merged 1 commit into from Apr 29, 2020

Conversation

FearlessTobi
Copy link
Contributor

@FearlessTobi FearlessTobi commented Apr 29, 2020

Previously, we were returning a value that was way too big, causing an integer overflow in Fractured Souls.
According to wwylele, the biggest observed save size for 3DS is 1MB, so this new value should leave plenty of room, even if games use a bigger size.

Fixes #1320.
Thanks to xperia64, Subv, wwylele, Hamish and B3N30 for investigating this on Discord.


This change is Reviewable

Previously, we were returning a value that was way too big, causing an integer overflow in Fractured Souls.
According to wwylele, the biggest oberserved save size for 3DS is 1MB, so this new value should leave plenty of room, even if games use a bigger size.
Subv
Subv approved these changes Apr 29, 2020
@Dragios
Copy link
Contributor

Dragios commented Apr 29, 2020

You forgot to include hamish as well. Anyway this can be instamerged.

@zhaowenlan1779 zhaowenlan1779 merged commit c937876 into citra-emu:master Apr 29, 2020
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants