Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update teakra, adjust TeakraSlice for new audio frame period #5402

Merged
merged 1 commit into from Jun 11, 2020

Conversation

xperia64
Copy link
Contributor

@xperia64 xperia64 commented Jun 8, 2020

This PR is the equivalent of #5266 for the LLE backend.

Previously, Teakra assumed a period of 4100. This was found to be incorrect, and was updated to 4096. While this Teakra update did correct the overall audio sync, it dropped audio entirely from time to time, resulting in large discontinuities in the audio. I found this was related to the TeakraSlice value in the LLE audio backend, and found a value that appears to prevent drop outs with the Teakra update.

This PR is a WIP because I am unsure how the TeakraSlice value should be derived, if it can be at all. It appears the drop outs are caused by Teakra getting "out-of-phase" with the rest of Citra, as if it's exiting before it finishes handing off samples, and carefully selecting a slice value can keep Teakra "in-phase". The value I selected in this update is 16384, or 4096 * 4. The old value of 20000 did not work, nor did 4096 * 5.


This change is Reviewable

@xperia64 xperia64 requested a review from wwylele Jun 8, 2020
wwylele
wwylele approved these changes Jun 8, 2020
@xperia64 xperia64 changed the title [WIP] Update teakra, adjust TeakraSlice for new audio frame period Update teakra, adjust TeakraSlice for new audio frame period Jun 11, 2020
@xperia64 xperia64 marked this pull request as ready for review Jun 11, 2020
@xperia64
Copy link
Contributor Author

xperia64 commented Jun 11, 2020

See #5266 (comment)
The behavior change in this PR appears to be correct.

@zhaowenlan1779 zhaowenlan1779 merged commit 5b245aa into citra-emu:master Jun 11, 2020
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants