New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http client squeezed double slashes #231

Closed
rhuss opened this Issue Apr 2, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@rhuss
Contributor

rhuss commented Apr 2, 2017

When using double slashes in GET requests with http().client().send.get() with the Java DSL with an URL /jolokia/read/jolokia.it:type=naming!/,name=!/slash-simple!//Ok then this gets out to the wire as:

17:48:50.895 [main] DEBUG com.consol.citrus.http.interceptor.LoggingClientInterceptor - Sending Http request message
17:48:50.895 [main] DEBUG Logger.Message_OUT - GET http://localhost:32795/jolokia/read/jolokia.it:type=naming!/,name=!/slash-simple!/Ok
Accept:text/plain, application/json, application/*+json, */*
Content-Type:text/plain;charset=UTF-8
Content-Length:0
....

Note that instead of the double slash only a single slash is used.

@christophd

This comment has been minimized.

Member

christophd commented Apr 10, 2017

Citrus uses Spring RestTemplate and underlying Apache Http client implementation. Seems to be an issue with underlying Apache Http client not being able to handle that double slash in URI. Saw this question on stack overflow (http://stackoverflow.com/questions/7530359/access-url-with-double-slash-with-httpclient) which states that double slashes are not supported by Apache Http client. By the way are these double slashes valid according to Http specs?

@christophd christophd added this to the v2.7.2 milestone May 29, 2017

@christophd christophd added the wontfix label Jun 30, 2017

@christophd christophd closed this Jun 30, 2017

@christophd christophd removed the READY label Jun 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment