Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom web-driver is not working with citrus-selenium #260

Closed
AndreasWier opened this Issue Jun 21, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@AndreasWier
Copy link

AndreasWier commented Jun 21, 2017

When I specify a custom web-driver with citrus-selenium 2.7.1:

<citrus-selenium:browser id="seleniumBrowser"
            type="custom"
            web-driver="marionetteDriver"
            start-page="${base.uri}/"/>

and start my test, then I get the error:

CitrusRuntimeException: Unsupported local browser type: custom

I think, this is because in
https://github.com/christophd/citrus/blob/master/modules/citrus-selenium/src/main/java/com/consol/citrus/selenium/endpoint/SeleniumBrowser.java#start()
method

the WebDriver is overwridden by the code:

            if (getEndpointConfiguration().getWebDriver() != null) {
                webDriver = getEndpointConfiguration().getWebDriver();
            } if (StringUtils.hasText(getEndpointConfiguration().getRemoteServerUrl())) {
                webDriver = createRemoteWebDriver(getEndpointConfiguration().getBrowserType(), getEndpointConfiguration().getRemoteServerUrl());
            } else {
                webDriver = createLocalWebDriver(getEndpointConfiguration().getBrowserType());
            }

I think in line 102 it should be an else if.

Does anyone agree with my guess?

@christophd

This comment has been minimized.

Copy link
Member

christophd commented Jun 22, 2017

Confirmed, thank you for pointing to it!

@christophd christophd added this to the v2.7.2 milestone Jun 22, 2017

@christophd christophd added IN PROGRESS and removed READY labels Jun 28, 2017

@christophd christophd self-assigned this Jun 28, 2017

@christophd christophd removed the IN PROGRESS label Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.