New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary surefire excludes #363

Closed
svettwer opened this Issue Apr 21, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@svettwer
Member

svettwer commented Apr 21, 2018

The maven-surefire documentation states:

By default, the Surefire Plugin will automatically include all test classes with the following wildcard patterns:

* "**/Test*.java" - includes all of its subdirectories and all Java filenames that start with "Test".
* "**/*Test.java" - includes all of its subdirectories and all Java filenames that end with "Test".
* "**/*Tests.java" - includes all of its subdirectories and all Java filenames that end with "Tests".
* "**/*TestCase.java" - includes all of its subdirectories and all Java filenames that end with "TestCase".

Therefore it's not required to exclude (^IT.*|.*IT)\.java tests in the configuration.

<plugin>
  <artifactId>maven-surefire-plugin</artifactId>
  <version>2.</version>
  <configuration>
    <forkMode>once</forkMode>
    <failIfNoTests>false</failIfNoTests>
    <!-- Not required -->
    <!-- <excludes> -->
      <!-- <exclude>**/IT*.java</exclude> -->
      <!-- <exclude>**/*IT.java</exclude> -->
    <!-- </excludes> -->
    <workingDirectory>${project.build.directory}</workingDirectory>
  </configuration>
</plugin>

This occurs in the citrus pom.xml, in the documentation as well as in the archetypes.

@svettwer svettwer added this to the SOMEDAY milestone Apr 21, 2018

@christophd christophd modified the milestones: SOMEDAY, v2.7.5 May 1, 2018

@christophd christophd closed this in 7d531d6 May 4, 2018

@christophd christophd removed the READY label May 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment