Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify protobuf syntax version. #154

Merged
merged 1 commit into from Jul 21, 2017
Merged

Specify protobuf syntax version. #154

merged 1 commit into from Jul 21, 2017

Conversation

pykello
Copy link
Contributor

@pykello pykello commented Jul 21, 2017

Without this, we get the following build warning: "No syntax specified for the proto file: cstore.proto. Please use 'syntax = "proto2";' or 'syntax = "proto3";' to specify a syntax version. (Defaulted to proto2 syntax.)".

@pykello pykello changed the base branch from master to develop July 21, 2017 17:41
@pykello pykello requested a review from mtuncer July 21, 2017 17:42
Copy link
Member

@mtuncer mtuncer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds right. I was about to make this change too

@mtuncer mtuncer merged commit 6225d9b into develop Jul 21, 2017
@mtuncer mtuncer deleted the proto_version branch July 21, 2017 17:44
mtuncer pushed a commit that referenced this pull request Jul 21, 2017
uucico pushed a commit to uucico/cstore_fdw that referenced this pull request Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants