New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance fixes #140

Merged
merged 35 commits into from Apr 12, 2017

Conversation

Projects
None yet
2 participants
@MrMaksimize
Collaborator

MrMaksimize commented Mar 3, 2017

Lighthouse gives us a pretty bad report - 30/100

With @davidrleonard's help last night brought down time to first paint from 4.5 seconds to 0.5;

Also adding service worker.

Needs some cleanup, and depends on merging of @andrell81 design_work branch, so this is a hold

http://theia.datasd.org.s3.amazonaws.com/data.sandiego.gov_2017-03-02_19-26-42.html (original lighthouse report)

Ok, I'm going all in on the performance fixes:

  • Conditional loading of scripts based on page
  • Remove jkan admin
  • Integrate / test service worker
  • Provide icon for home screen saving
  • Provide manifest xml file
  • Remove bootswatch theme dependency
  • Move CDN assets as needed under the domain
  • Clean out gulpfile based on changes
  • Remove jquery
  • Add event listener that listens for dom content loaded, and appends additional link rels to the page
  • Bring images in to local paths

MrMaksimize added some commits Mar 3, 2017

Merge branch 'master' of github.com:cityofsandiego/seaboard into perf…
…-fixes-2

* 'master' of github.com:cityofsandiego/seaboard: (42 commits)
  Change urls for stories.
  Poseidon: get-it-done-311.md last updated 2017-03-03, != 2017-03-02.
  Poseidon: permits-issued.md last updated 2017-03-02, != 2017-03-01.
  Poseidon: permits-completed.md last updated 2017-03-02, != 2017-03-01.
  Poseidon: city-owned-properties-parcels.md last updated 2017-03-02, != 2017-03-01.
  Poseidon: business-listings.md last updated 2017-03-02, != 2017-03-01.
  Poseidon: police-calls-for-service.md last updated 2017-03-02, != 2017-03-01.
  Poseidon: permits-applied.md last updated 2017-03-02, != 2017-03-01.
  Poseidon: city-owned-properties-leases.md last updated 2017-03-02, != 2017-03-01.
  Poseidon: monitoring-of-indicator-bacteria-in-drinking-water.md last updated 2017-03-02, != 2017-03-01.
  Poseidon: code-enforcement-violations.md last updated 2017-03-02, != 2017-03-01.
  Poseidon: special-events.md last updated 2017-03-02, != 2017-03-01.
  Poseidon: city-owned-properties-details.md last updated 2017-03-02, != 2017-03-01.
  Poseidon: streets-repair-projects.md last updated 2017-03-02, != 2017-03-01.
  Poseidon: get-it-done-311.md last updated 2017-03-02, != 2017-03-01.
  Poseidon: permits-issued.md last updated 2017-03-01, != 2017-02-28.
  Poseidon: permits-completed.md last updated 2017-03-01, != 2017-02-28.
  Poseidon: parking-meters-transactions.md last updated 2017-03-01, != 2017-02-28.
  Poseidon: business-listings.md last updated 2017-03-01, != 2017-02-28.
  Poseidon: city-owned-properties-details.md last updated 2017-03-01, != 2017-02-28.
  ...
Merge branch 'design_work' of github.com:cityofsandiego/seaboard into…
… perf-fixes-2

* 'design_work' of github.com:cityofsandiego/seaboard:
  Fixing link to blog post in latest news rail
  Latest news rail final
  Keen cached query
Merge branch 'master' of github.com:cityofsandiego/seaboard into perf…
…-fixes-2

* 'master' of github.com:cityofsandiego/seaboard:
@MrMaksimize

This comment has been minimized.

Collaborator

MrMaksimize commented Mar 4, 2017

All that's left is fixing gulp build for production

@MrMaksimize

This comment has been minimized.

Collaborator

MrMaksimize commented Mar 5, 2017

Currently blocked by us getting an SSL cert for data.sandiego.gov

@MrMaksimize

This comment has been minimized.

Collaborator

MrMaksimize commented Mar 7, 2017

FYI - service worker will get stuck in your local chrome. Need to think of how to bust that.

MrMaksimize added some commits Mar 16, 2017

Merge branch 'master' of github.com:cityofsandiego/seaboard into perf…
…-fixes-2

* 'master' of github.com:cityofsandiego/seaboard: (170 commits)
  Poseidon: get-it-done-311.md last updated 2017-03-16, != 2017-03-15.
  Poseidon: solar-permits.md last updated 2017-03-15, != 2017-03-14.
  Poseidon: permits-issued.md last updated 2017-03-15, != 2017-03-14.
  Poseidon: monitoring-of-indicator-bacteria-in-drinking-water.md last updated 2017-03-15, != 2017-03-14.
  Poseidon: permits-completed.md last updated 2017-03-15, != 2017-03-14.
  Poseidon: police-calls-for-service.md last updated 2017-03-15, != 2017-03-14.
  Poseidon: business-listings.md last updated 2017-03-15, != 2017-03-14.
  Poseidon: code-enforcement-violations.md last updated 2017-03-15, != 2017-03-14.
  Poseidon: parking-meters-transactions.md last updated 2017-03-15, != 2017-03-14.
  Poseidon: permits-applied.md last updated 2017-03-15, != 2017-03-14.
  Poseidon: city-owned-properties-parcels.md last updated 2017-03-15, != 2017-03-14.
  Poseidon: special-events.md last updated 2017-03-15, != 2017-03-14.
  Poseidon: city-owned-properties-leases.md last updated 2017-03-15, != 2017-03-13.
  Poseidon: streets-repair-projects.md last updated 2017-03-15, != 2017-03-14.
  Poseidon: get-it-done-311.md last updated 2017-03-15, != 2017-03-14.
  Poseidon: solar-permits.md last updated 2017-03-14, != 2017-03-13.
  Poseidon: permits-issued.md last updated 2017-03-14, != 2017-03-13.
  Poseidon: permits-completed.md last updated 2017-03-14, != 2017-03-13.
  Poseidon: city-owned-properties-details.md last updated 2017-03-14, != 2017-03-13.
  Poseidon: city-owned-properties-parcels.md last updated 2017-03-14, != 2017-03-13.
  ...
@MrMaksimize

This comment has been minimized.

Collaborator

MrMaksimize commented Mar 18, 2017

Latest changes bring it up to 83.

http://theia.datasd.org.s3.amazonaws.com/performer-hare-68626.netlify.com_2017-03-17_16-28-46.html

Performance is up from 24 to 56.

Site now fully able to operate offline.

@MrMaksimize

This comment has been minimized.

Collaborator

MrMaksimize commented Mar 18, 2017

At this point I'm probably getting into the obsessive range:
http://theia.datasd.org.s3.amazonaws.com/performer-hare-68626.netlify.com_2017-03-17_22-50-48.html

90 overall on lighthouse.

Next steps = review IE compat;
Review image optimization
Review critical request chain (polymer loads multiple times)

@MrMaksimize MrMaksimize changed the title from [HOLD | WIP] Performance fixes to Performance fixes Apr 12, 2017

@MrMaksimize

This comment has been minimized.

Collaborator

MrMaksimize commented Apr 12, 2017

Ok - @andrell81 and @arnaudvedy need review from you here. There's a ton of changes here I removed the WIP / Hold tags. Please check this out tomorrow AM, and we'll roll to staging, then prod :)

@andrell81 andrell81 merged commit cd0cbac into master Apr 12, 2017

@andrell81 andrell81 removed the in progress label Apr 12, 2017

@andrell81 andrell81 deleted the perf-fixes-2 branch Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment