Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages on data source loading are unclear #1218

Open
equivalentideas opened this issue Sep 26, 2017 · 4 comments

Comments

@equivalentideas
Copy link

commented Sep 26, 2017

We've got an error on a data source "error — last updated Sept. 26, 2017, 12:20 a.m":

screen shot 2017-09-26 at 12 04 23 pm

It's not clear what is causing this error or what we can do to fix it.

We've also got an error on an old data source, that contains some people with the same popolo id, in case that's relevant (it's not clear what's causing that error either ;-P ):

screen shot 2017-09-26 at 12 04 16 pm

@equivalentideas

This comment has been minimized.

Copy link
Author

commented Sep 26, 2017

Also, some quick help to resolve this error would be highly appreciated 🙏

@mhl

This comment has been minimized.

Copy link
Collaborator

commented Sep 26, 2017

As I've mentioned before, we (mySociety) are only working on the Django 1.8 / django-popolo version of write-it now, which has moved on considerably from the version deployed on writeinpublic.com, but hopefully I can help find the problem with the data anyway...

I think the first error, which isn't being displayed in the interface, is a ValidationError for an invalid email address in:

    "email": "http://www.coonambleshire.nsw.gov.au/AboutCouncil/keadys@bigpond.com", 
    "id": "coonamble_shire_council/danny_keady", 
    "image": "http://www.coonambleshire.nsw.gov.au/2015/_media/content/councillors/danny-keady.jpg", 
    "images": [
        {
            "url": "http://www.coonambleshire.nsw.gov.au/2015/_media/content/councillors/danny-keady.jpg"
        }
    ], 
    "name": "Danny Keady", 
    "sources": [
        {
            "url": "http://www.coonambleshire.nsw.gov.au/AboutCouncil/councillors.html"
        }
    ]
}

So hopefully if you fix that and resync, it'll start working again.

I don't think the second error is relevant: that URL is a 404, so it looks like it's trying to parse the error page as JSON. (Obviously that should be checking the status code to produce a more helpful error.)

@equivalentideas

This comment has been minimized.

Copy link
Author

commented Sep 29, 2017

As I've mentioned before, we (mySociety) are only working on the Django 1.8 / django-popolo version of write-it now, which has moved on considerably from the version deployed on writeinpublic.com, but hopefully I can help find the problem with the data anyway...

Thanks so much for this @mhl I really appreciate it. I'm looking into your suggestion now.

equivalentideas added a commit to openaustralia/australian_local_councillors_popolo that referenced this issue Sep 29, 2017
@equivalentideas

This comment has been minimized.

Copy link
Author

commented Sep 29, 2017

So hopefully if you fix that and resync, it'll start working again.

Unfortunately it's still showing an error. Would you mind checking what the error is now for me? I really appreciate your help with this @mhl 🙏

I don't think the second error is relevant: that URL is a 404, so it looks like it's trying to parse the error page as JSON. (Obviously that should be checking the status code to produce a more helpful error.)

Yep that's expected 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.