New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20847 updating PINGBACK_URL to https in CRM_Utils_VersionCheck #10408

Merged
merged 1 commit into from Jun 12, 2017

Conversation

Projects
None yet
3 participants
@jackrabbithanna
Contributor

jackrabbithanna commented May 24, 2017

@civicrm-builder

This comment has been minimized.

Show comment
Hide comment
@civicrm-builder

civicrm-builder May 24, 2017

Can one of the admins verify this patch?

civicrm-builder commented May 24, 2017

Can one of the admins verify this patch?

@civicrm-builder civicrm-builder added the 4.6 label May 24, 2017

@jackrabbithanna

This comment has been minimized.

Show comment
Hide comment
@jackrabbithanna

jackrabbithanna May 24, 2017

Contributor

Backported from #10373
Pretty much a no-brainer, merging

Contributor

jackrabbithanna commented May 24, 2017

Backported from #10373
Pretty much a no-brainer, merging

@seamuslee001

This comment has been minimized.

Show comment
Hide comment
@seamuslee001

seamuslee001 May 24, 2017

Contributor

Just noting we should not merge until after June 7

Contributor

seamuslee001 commented May 24, 2017

Just noting we should not merge until after June 7

@jackrabbithanna

This comment has been minimized.

Show comment
Hide comment
@jackrabbithanna

jackrabbithanna May 24, 2017

Contributor

@seamuslee001 ok, you got that message in there just in time :)

Contributor

jackrabbithanna commented May 24, 2017

@seamuslee001 ok, you got that message in there just in time :)

@seamuslee001

This comment has been minimized.

Show comment
Hide comment
@seamuslee001

seamuslee001 May 24, 2017

Contributor

@jackrabbithanna Unless we aren't gonna do a release of 4.6 in June then its ok to merge if we are doing a June 4.6 release then we need to hold until after then

Contributor

seamuslee001 commented May 24, 2017

@jackrabbithanna Unless we aren't gonna do a release of 4.6 in June then its ok to merge if we are doing a June 4.6 release then we need to hold until after then

@jackrabbithanna

This comment has been minimized.

Show comment
Hide comment
@jackrabbithanna

jackrabbithanna May 24, 2017

Contributor

I think that is TBD at this moment, so we'll hold

Contributor

jackrabbithanna commented May 24, 2017

I think that is TBD at this moment, so we'll hold

@seamuslee001

This comment has been minimized.

Show comment
Hide comment
@seamuslee001

seamuslee001 May 25, 2017

Contributor

Jenkins test this please

Contributor

seamuslee001 commented May 25, 2017

Jenkins test this please

@jackrabbithanna

This comment has been minimized.

Show comment
Hide comment
@jackrabbithanna

jackrabbithanna Jun 12, 2017

Contributor

Merging #10408

Contributor

jackrabbithanna commented Jun 12, 2017

Merging #10408

@jackrabbithanna jackrabbithanna merged commit e20a985 into civicrm:4.6 Jun 12, 2017

1 check passed

default Build finished.
Details

@jackrabbithanna jackrabbithanna deleted the jackrabbithanna:CRM-20487 branch Jun 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment