Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20768 - Installer UI - Accept mysql port #10555

Merged
merged 3 commits into from Jun 25, 2017

Conversation

totten
Copy link
Member

@totten totten commented Jun 23, 2017

== Background ==

In previous releases, the web-based installation script allowed you to enter
the MySQL "server" with a host:port combination (e.g. 127.0.0.1:3307).

I believe this regressed during the mysql=>mysqli transition.

== Before ==

If you use the web-based install UI and enter a host:port combination, the
error messages indicate a confusing mix of information (e.g. some
indicating port 3306, some indicating port 3307).

== After ==

If you use the web-based install UI and enter a host:port combination, it
uses the specified port.

(This is a resubmission of #10553 for 4.7.21-rc.)


== Background ==

In previous releases, the web-based installation script allowed you to enter
the MySQL "server" with a `host:port` combination (e.g.  `127.0.0.1:3307`).

I believe this regressed during the mysql=>mysqli transition.

== Before ==

If you use the web-based install UI and enter a `host:port` combination, the
error messages indicate a confusing mix of information (e.g.  some
indicating port 3306, some indicating port 3307).

== After ==

If you use the web-based install UI and enter a `host:port` combination, it
uses the specified port.

----------------------------------------
* CRM-20768: Web-based installation should accept non-standard MySQL port
  https://issues.civicrm.org/jira/browse/CRM-20768
Copy link
Contributor

@seamuslee001 seamuslee001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@totten this looks good to me

@seamuslee001
Copy link
Contributor

@eileenmcnaughton thoughts on this?

@eileenmcnaughton
Copy link
Contributor

I agree @seamuslee001 - makes perfect sense & should have no impact on the currently working passing of $server with no port so seems safe

@eileenmcnaughton eileenmcnaughton merged commit a24ca51 into civicrm:4.7.21-rc Jun 25, 2017
@totten totten deleted the 4.7.21-install-port branch June 26, 2017 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants