Towards CRM-15861 consolidate default function on shared class #10887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileenmcnaughton
force-pushed
the
member
branch
from
95c98ad
to
426cbcc
Compare
eileenmcnaughton
force-pushed
the
member
branch
from
426cbcc
to
f525ec1
Compare
eileenmcnaughton
changed the title
eileenmcnaughton
changed the title
|
Nice change. Tested on local works fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code consolidation
Before
Handling is repeated in 2 places
After
Code is consolidated
Technical Details
This is a minor extract of #9216 intended to pull a small portion of that work into a commitable code improvement
Comments