Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-21203 Fixes for Joomla 3.8+ CRON/cli and directories #11062

Merged
merged 3 commits into from Oct 19, 2017

Conversation

@mattwire
Copy link
Contributor

@mattwire mattwire commented Oct 3, 2017

Work in progress fixes for Joomla 3.8 to fix cli.php and cron.php


@mattwire mattwire changed the title CRM-21203 joomla cli 3 8 0 WIP CRM-21203 joomla cli 3 8 0 Oct 3, 2017
@mattwire mattwire changed the title WIP CRM-21203 joomla cli 3 8 0 CRM-21203 Fixes for Joomla 3.8+ CRON/cli and directories Oct 12, 2017
@vingle
Copy link
Contributor

@vingle vingle commented Oct 14, 2017

I've tested this on Joomla 3.8.1 and J3.7.5 with CiviCRM 4.7.25 and confirm crons are running as expected, with no adverse behaviour.

@mattwire
Copy link
Contributor Author

@mattwire mattwire commented Oct 18, 2017

@totten Thoughts on merging? Without it civi on Joomla is a bit broken... and it doesn't seem to have any adverse effects for those who have installed. As it only touches one file it can't impact anything other than Joomla sites...

@seamuslee001
Copy link
Contributor

@seamuslee001 seamuslee001 commented Oct 19, 2017

I think the code makes sense and is limited to Joomla integration only. I have seen supportive comments in JIRA and here that this fixes the issues reported. I think this is good to merge @totten @eileenmcnaughton

@eileenmcnaughton eileenmcnaughton merged commit cdb0a39 into civicrm:master Oct 19, 2017
1 check passed
1 check passed
default Build finished.
Details
@jorich-2000
Copy link

@jorich-2000 jorich-2000 commented Oct 28, 2017

I have tried this on a couple of joomla 3.8.1 sites running under PHP 7.0.24 and 7.1.16 - although CRON runs I get a list of warnings:
/httpdocs/administrator/components/com_civicrm/civicrm/bin/cli.php" successfully completed in 1 seconds, output:

PHP Notice: Constant JPATH_ISWIN already defined in /var/www/vhosts/nlcbanham.org.uk/httpdocs/libraries/import.legacy.php on line 64
PHP Notice: Constant JPATH_ISMAC already defined in /var/www/vhosts/nlcbanham.org.uk/httpdocs/libraries/import.legacy.php on line 65
PHP Notice: Constant JROUTER_MODE_RAW already defined in /var/www/vhosts/nlcbanham.org.uk/httpdocs/libraries/import.legacy.php on line 72
PHP Notice: Constant JROUTER_MODE_SEF already defined in /var/www/vhosts/nlcbanham.org.uk/httpdocs/libraries/import.legacy.php on line 79
PHP Notice: Constant JROUTER_MODE_RAW already defined in /var/www/vhosts/nlcbanham.org.uk/httpdocs/libraries/import.php on line 60
PHP Notice: Constant JROUTER_MODE_SEF already defined in /var/www/vhosts/nlcbanham.org.uk/httpdocs/libraries/import.php on line 67

@mattwire mattwire deleted the mattwire:CRM-21203_joomla_cli_3_8_0 branch Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants