Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(NFC) Update version in header #11999

Merged
merged 1 commit into from Apr 19, 2018

Conversation

@totten
Copy link
Member

commented Apr 19, 2018

This is a simple administrative update to the headers. It was generated with the command:

rgrep '| CiviCRM version 4.7' CRM/ Civi ang api bin extern install/ settings/ templates -l \
  | xargs sed -i'' "s/| CiviCRM version 4.7/| CiviCRM version 5  /g"

The inclusion of | aimed to avoid matching any non-header text (e.g. inline docs that
mentioned the version incidentally). But then I did a looser search for just

rgrep 'CiviCRM version 4.7'

and manually patched the remainder.

Note: I'm not really keen on doing this every month, so I relaxed the header
statement -- instead of CiviCRM version 5.0, it's just CiviCRM version 5.

(NFC) Update version in header
This is a simple administrative update to the headers. It was generated with the command:

```
rgrep '| CiviCRM version 4.7' CRM/ Civi ang api bin extern install/ settings/ templates -l \
  | xargs sed -i'' "s/| CiviCRM version 4.7/| CiviCRM version 5  /g"
```

Tthe inclusion of `|` aimed to avoid matching any non-header text (e.g. inline docs that
mentioned the version incidentally). But then I did a looser search and for just

```
rgrep 'CiviCRM version 4.7'
````

and manually patched the remainder.

Note: I'm not really keen on doing this every month, so I relaxed the header
statement -- instead of `CiviCRM version 5.0`, it's just `CiviCRM version 5`.
@eileenmcnaughton

This comment has been minimized.

Copy link
Contributor

commented Apr 19, 2018

I spot checked 20 or so files & change seems solid.

@eileenmcnaughton eileenmcnaughton merged commit 3d04355 into civicrm:master Apr 19, 2018

1 check passed

default Build finished.
Details

@totten totten deleted the totten:master-header branch Apr 19, 2018

totten added a commit to totten/civicrm-core that referenced this pull request Apr 25, 2018
(NFC) Update version headers in `xml/`
This is a simple administrative update to the headers. It's a follow-up to
civicrm#11999 (fee1419).

This addresses a small discrepancy -- after running GenCode locally, some files would be changed
back to `version 4.7`. Now they'll stay as `version 5`.
totten added a commit to totten/civicrm-core that referenced this pull request Apr 25, 2018
(NFC) Update version headers in `sql/`
This is a simple administrative update to the headers. It's a follow-up to
civicrm#11999 (fee1419)
which addresses some files missed by the previous search.
totten added a commit to totten/civicrm-core that referenced this pull request Apr 25, 2018
(NFC) Update version headers in `tools/`
This is a simple administrative update to the headers. It's a follow-up to
civicrm#11999 (fee1419)
which addresses some files missed by the previous search.
totten added a commit to totten/civicrm-core that referenced this pull request Apr 25, 2018
(NFC) Update version headers in `header*`
This is a simple administrative update to the headers. It's a follow-up to
civicrm#11999 (fee1419)
which addresses some files missed by the previous search.
totten added a commit to totten/civicrm-core that referenced this pull request Apr 25, 2018
(NFC) Update version headers in `tests/`
This is a simple administrative update to the headers. It's a follow-up to
civicrm#11999 (fee1419)
which addresses some files missed by the previous search.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.