Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#38 Fix inappropriate limit on participant.getcount #12203

Merged
merged 1 commit into from May 25, 2018

Conversation

Projects
None yet
3 participants
@eileenmcnaughton
Copy link
Contributor

commented May 24, 2018

Overview

Fix API Participant getcount returns 25 when it should be higher

Before

DB with 27 participants returns 25 with participant.getcount api call (no criteria)

After

Above call returns 25

Technical Details

Comments

@seamuslee001

This comment has been minimized.

Copy link
Contributor

commented May 24, 2018

Change makes sense to me Adding merge on pass as i believe its good. @eileenmcnaughton any thought of moving the test from participant to doing it as a SyntaxConformanceTest instead?

@eileenmcnaughton

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2018

@seamuslee001 I kinda left that off just because of the time it would take for every single entity

@seamuslee001

This comment has been minimized.

Copy link
Contributor

commented May 25, 2018

@eileenmcnaughton maybe move the code to syntaxConformance but have like

if ($entity != 'Participant') {
  Mark test as Incomplete?
}
@eileenmcnaughton

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2018

test this please

@eileenmcnaughton

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2018

That feels at least as ugly, maybe more

@eileenmcnaughton

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2018

Merging as Seamus said he was adding merge-on-pass (although he didn't)

@eileenmcnaughton eileenmcnaughton merged commit 5897b05 into civicrm:master May 25, 2018

1 check passed

default Build finished.
Details

@eileenmcnaughton eileenmcnaughton deleted the eileenmcnaughton:api_tester branch May 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.