Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/mail#11 add CRM_Mailing_BAO_MailingJob::del() #12275

Merged
merged 1 commit into from Jun 6, 2018

Conversation

Projects
None yet
3 participants
@monishdeb
Copy link
Member

commented Jun 6, 2018

Overview

This PR adds CRM_Mailing_BAO_MailingJob::del($id)

Before

  1. No delete fn present
  2. No Pre/Post hook on del fn

After

  1. Add CRM_Mailing_BAO_MailingJob::deleteMailingJob to delete Mailing Jobs and add pre/post delete hook
  2. Replace all the DAO call with corresponding delete fn in the codebase.
@civibot

This comment has been minimized.

Copy link

commented Jun 6, 2018

(Standard links)

@eileenmcnaughton

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2018

OK looks good. Change is small & clear cut, merging

@eileenmcnaughton eileenmcnaughton merged commit 400d5b6 into civicrm:master Jun 6, 2018

1 check passed

default Build finished.
Details

@monishdeb monishdeb deleted the JMAConsulting:dev_mail_11-1 branch Jun 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.