Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buttons to 'Cleanup caches and update paths' in standard way #14509

Merged

Conversation

@mattwire
Copy link
Contributor

commented Jun 13, 2019

Overview

Change to standard method to add buttons to this form

Before

Added using hardcoded method on form. Not using standard formButtons template.

After

Added using standard formButtons method.
image

Technical Details

Comments

This allows themes such as haystack (shown) to theme buttons consistently.

@civibot

This comment has been minimized.

Copy link

commented Jun 13, 2019

(Standard links)

@civibot civibot bot added the master label Jun 13, 2019

@eileenmcnaughton

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

@demeritcowboy this might be one you could look at if you get some headspace

@demeritcowboy

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

  • General standards
    • [r-explain] PASS
    • [r-user] PASS
    • [r-doc] PASS
    • [r-run] PASS Works.
  • Developer standards
    • [r-tech] PASS
    • [r-code] Issue Just the icons mentioned above, unless it was intentional.
    • [r-maint] N/A
    • [r-test] PASS
@eileenmcnaughton

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

@mattwire I'm happy for you to merge this once you've considered @demeritcowboy's feedback as it appears to be 'optional' feedback with an overall 'pass' (or even B+ :))

@mattwire mattwire force-pushed the mattwire:buttons_settings_cleanupcache_standard branch from dad5cfb to e4d3eb1 Jun 16, 2019

@seamuslee001 seamuslee001 merged commit b2ffd68 into civicrm:master Jun 16, 2019

1 check passed

default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.