Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up fix on start as a url parameter #14611

Merged
merged 1 commit into from Jun 23, 2019

Conversation

@eileenmcnaughton
Copy link
Contributor

commented Jun 23, 2019

Overview

Re-instates report for 'start' & 'end' in search urls - but deprecates them

Before

start=2018-01-01 wasn't working on contribution search

After

works but gives a deprecation notice

Technical Details

Moving to stdised urls but should still support this for a while - as it's used from core

Comments

@seamuslee001

@civibot

This comment has been minimized.

Copy link

commented Jun 23, 2019

(Standard links)

@civibot civibot bot added the master label Jun 23, 2019

if (!empty($highReceiveDate)) {
$this->_formValues['receive_date_high'] = date('Y-m-d H:i:s', strtotime($highReceiveDate));
CRM_Core_Error::deprecatedFunctionWarning('pass receive_date_high not end');
}

This comment has been minimized.

Copy link
@seamuslee001

seamuslee001 Jun 23, 2019

Contributor

@eileenmcnaughton do we need to port the relative_handling as well?

This comment has been minimized.

Copy link
@eileenmcnaughton

eileenmcnaughton Jun 23, 2019

Author Contributor

@seamuslee001 so I think the relative date handling is not handling the relative date in the url but ensuring it is zero'd if the high or low are set - which I think IS handled in the generic handling

@seamuslee001

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2019

@eileenmcnaughton this looks fine to me once my question is resolved, however i'm still not seeing any sign the values are actually being passed to the query

@eileenmcnaughton

This comment has been minimized.

Copy link
Contributor Author

commented Jun 23, 2019

test fails unrelated (we can probably spare ourselves re-running them as I think this is ready to merge?)

@seamuslee001

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2019

@eileenmcnaughton yeh ok to merge. I can re-rest in RC

@eileenmcnaughton eileenmcnaughton merged commit 478a85e into civicrm:master Jun 23, 2019

1 check failed

default Build finished.
Details

@eileenmcnaughton eileenmcnaughton deleted the eileenmcnaughton:url_support branch Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.