Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
dev/core#1120 remove multiple export handling #14830
Per https://lab.civicrm.org/dev/core/issues/1120 I'm not convinced the current merge code does 'what it says on the box'
It implies that both the drop down option or the 'other' string only kick in with > 2 contacts with the same address. In fact it seems that they both kick in with any merge but there is code that attempts to only apply the 'other' string for 2 or more (I'm not sure it succeeds since I wrote a unit test before I moved that code around & it seemed to show the 'other' string being used for 2 contacts). This simplifies to doing more or less what the code seems to do.
More discussion in https://lab.civicrm.org/dev/core/issues/1120 but I think at best it applies the 2 or more rule to the 'other' rather than the variants and 'other'
It's not clear to me how this alters existing functionality. I agree that the terminology ">2" is confusing, and I don't think it was intended to make a distinction between merging two contacts and merging more than two contacts -- it was just poorly worded, and your change is more accurate to the intent. But beyond the terminology change, it's not clear what the code changes accomplish. Are you saying that the code did make a distinction between merging 2 vs. merging > 2? And this simplifies to any merge? If so -- I'm in favor.
@lcdservices the code definitely attempted to treat > 2 differently than just 2. I'm not sure how well that worked since it only attempted it for the 'other' string - not the list or the option value and I have some doubts even then since I'm pretty sure we merged this test