Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ref] [Export] Remove exportComponent function - it's not adding much here #14875

Merged
merged 1 commit into from Jul 28, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Sometimes an array is much easier to read than a switch....

Before

Long switch

After

array

Technical Details

Removes a function that is adding confusion rather than helping

Comments

@civibot
Copy link

civibot bot commented Jul 24, 2019

(Standard links)

@civibot civibot bot added the master label Jul 24, 2019
@eileenmcnaughton
Copy link
Contributor Author

@colemanw wanna merge this & #14874

@colemanw
Copy link
Member

It was a dumb function.

@colemanw colemanw merged commit ffde4ea into civicrm:master Jul 28, 2019
@colemanw colemanw deleted the export_2 branch July 28, 2019 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants