Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
dev/core#378 Determine front end pages in drupal #14876
Alternative to https://github.com/civicrm/civicrm-drupal/pull/546/files that I think narrows the scope
Cannot assign to front end pages in drupal
Per https://lab.civicrm.org/dev/core/issues/378#note_20974 in 5.16 it's possible to designate front end page themes in Joomla! and WP but not drupal. @seamuslee001 proposed civicrm/civicrm-drupal#546 to address that. However, it altered the config variable
This gets around that by adding a function to retrieve whether it is a front end page which accesses the variable for Joomla! & WP but uses @seamuslee001's method for Drupal.
I don't know if there are any special concerns for D8 -but they are mitigated by the fact that front end themes are entirely new & will only affect those adjusting to the new setting.
I have targeted the 5.16rc as both the change this extends & the current shoreditch work target 5.16
Oh - the checkbox is still hidden for drupal
We can worry about that if this is agreed