Core/dev#692 : Support search arguments to Case Search form #15370
Conversation
|
(Standard links)
|
|
@monishdeb Does the search function return the right results for you when using url params? I tried it on the test site here with the exact same url arguments as in the screenshot ( Also, when searching for subject normally on the form not using url params, I get a warning here that I don't see on dmaster: |
|
I think there are a couple more things that need to be done
I think this is mergable once 3 is fixed as that is a regression - the other 2 can follow as this is a code tidy up. The notice is coming out of the qill - I put up a separate PR here #15373 that extracts various functions used on the contribution search that would ideally be reused to help you here |
|
Specifically https://github.com/civicrm/civicrm-core/pull/15373/files#diff-ca3790966db8d584af7de8f6c6b7abfbR157 should handle the qill thing Opps - now removed that to break it up - above is out of date |
|
Also a variant of this should work on the url https://github.com/civicrm/civicrm-core/pull/15373/files#diff-1933fff668010b3ebd72ee4070e82f00R109 |
This consolidates 2 places where formValues are determined on contribution search. In one place force is handled in the other retrieving from the form is handled. It seems Ok to handle both in one place & call that. This might help iron on some glitches Monish is hitting on civicrm#15370 We should probably add saved search retrieval in too To confirm this works use this url civicrm/contribute/search?reset=1&reset=1&sort_name=p&receive_date_high=20180101&force=1 - it should filter. If you add another criteria to the form afterwards the url criteria should be present on the form from the url & the new one should also be respected. If you actively remove the url criteria on the form it is ignored in the search
This consolidates 2 places where formValues are determined on contribution search. In one place force is handled in the other retrieving from the form is handled. It seems Ok to handle both in one place & call that. This might help iron on some glitches Monish is hitting on civicrm#15370 We should probably add saved search retrieval in too To confirm this works use this url civicrm/contribute/search?reset=1&reset=1&sort_name=p&receive_date_high=20180101&force=1 - it should filter. If you add another criteria to the form afterwards the url criteria should be present on the form from the url & the new one should also be respected. If you actively remove the url criteria on the form it is ignored in the search
This consolidates 2 places where formValues are determined on contribution search. In one place force is handled in the other retrieving from the form is handled. It seems Ok to handle both in one place & call that. This might help iron on some glitches Monish is hitting on civicrm#15370 We should probably add saved search retrieval in too To confirm this works use this url civicrm/contribute/search?reset=1&reset=1&sort_name=p&receive_date_high=20180101&force=1 - it should filter. If you add another criteria to the form afterwards the url criteria should be present on the form from the url & the new one should also be respected. If you actively remove the url criteria on the form it is ignored in the search
This consolidates 2 places where formValues are determined on contribution search. In one place force is handled in the other retrieving from the form is handled. It seems Ok to handle both in one place & call that. This might help iron on some glitches Monish is hitting on civicrm#15370 We should probably add saved search retrieval in too To confirm this works use this url civicrm/contribute/search?reset=1&reset=1&sort_name=p&receive_date_high=20180101&force=1 - it should filter. If you add another criteria to the form afterwards the url criteria should be present on the form from the url & the new one should also be respected. If you actively remove the url criteria on the form it is ignored in the search
|
merging this - per discussion #15614 will make sure the previous blocker (3 above) is fixed post merge |
Overview
This PR extends the fix and make all possible mailing search filters to be used as a url arguments on forced search using 'Find Mailing' or 'Advance Search'
Before
Search arguments didn't work
After
Search arguments works:
