dev/core#1293 Still output csv file on export, even if no rows are in it

[eileenmcnaughton]

Overview

Fixes a bug where output is confusing when there are no rows

Before

1. Do a contact search.
2. Select contacts so that none of them have a street address, the Do Not Mail choice, or deceased. E.g. pick a couple contacts where all they have is name and/or email.
3. Choose export from the dropdown.
4. Choose selected fields.
5. Check the box that says Exclude contacts with "do not mail" privacy, no street address, or who are deceased.
6. On the next page choose a field like Do Not Mail.
7. When you export you just get a blank screen and there's no errors anywhere. It's because there is no actual error, it's just that there are now zero contacts to export, but it also doesn't give you a zero-length file to download.

After

Step 7 works.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass
  • (r-user) Pass
  • (r-doc) Pass
  • (r-run) Pass replicated the issue and confirms that this fixes it and outputs an empty CSV which seems appropriate in this case
• Developer standards
  • (r-tech) Pass
  • (r-code) Pass
  • (r-maint) Pass
  • (r-test) Unknown