[REF] Remove early return on joinTable

[eileenmcnaughton]

Overview

Minor code cleanup - removes 2 unnecessary things

1. use of reference on $ids
2. a check that doesn't make sense here

Before

Code more confusing

After

Code less confusing

Technical Details

I looked up the reason for the early return here and it was that the UI for adding other tables
in was too complex. In other words the removed lines should never be true.

However, I don't think it's the place of the query object to enforce not attempting a query the
UI struggles with. Removing this will save a later person having to figure that out.

Re $ids - it's never used again so does not need to be a reference

Comments

_

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Change is fine by me merging