Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap some fatals on form & page classes for statusBounces #15770

Merged
merged 1 commit into from Nov 8, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Part of ongoing efforts to eliminate fatals in thee code

Before

calls fatal

After

Status bounces

Technical Details

Since these are on the form layer they should bounce rather than fatal

Comments

@civibot
Copy link

civibot bot commented Nov 8, 2019

(Standard links)

@civibot civibot bot added the master label Nov 8, 2019
@yashodha
Copy link
Contributor

yashodha commented Nov 8, 2019

@eileenmcnaughton looks good. A few strings are not translated though. Might be good to do that as well while you're at it.

@eileenmcnaughton
Copy link
Contributor Author

@yashodha I started to do one & quickly realised it was going to turn into a project on it's own!

@seamuslee001
Copy link
Contributor

I'm going to merge this as i think its a good idea and then will follow up with altering the strings for this PR

@seamuslee001 seamuslee001 merged commit fe8d0a0 into civicrm:master Nov 8, 2019
@seamuslee001 seamuslee001 deleted the except branch November 8, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants