dev/core#1366 - case audit printReport parameter is no longer used #16670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The printReport parameter to run() is no longer used because it's now always TRUE.
If you look at the files changed tab with the ignore whitespace setting turned on it's a little cleaner.
Technical Details
To see that it's no longer used, start by grepping for CRM_Case_Audit_Audit (exclude AuditConfig:
grep -r CRM_Case_Audit_Audit * | grep -v CRM_Case_Audit_AuditConfig
)Then to understand why it's never used, it's because the feature it supported was purposely bypassed in https://github.com/civicrm/civicrm-core/pull/15998/files#diff-fdb4ad333e7ba641428562199adc7dee, and thru some intermediate cleanup all other references to it have also been removed.
Comments
It's now also easier to see why PR #16660 was able to remove the Audit.tpl file since there's no references to it. The order of these PRs was backwards but it's the same result.
There's still more that can be removed but will be separate PRs.