Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting outBound_option readonly in UI #16774

Merged
merged 1 commit into from Mar 17, 2020

Conversation

mattwire
Copy link
Contributor

Overview

Follow on from #16451

Fix setting the SMTP outbound option readonly.

Before

outBound_option readonly ignored in UI. It was actually working, just not shown as frozen in UI.

After

Elements frozen if you set in civicrm.settings.php:
$civicrm_setting['mailing']['mailing_backend']['outBound_option'] = 5;

image

Technical Details

readonly attribute was set after adding the element!

Comments

@yashodha you were interested in this? I think it actually already works with the SMTP authentication setting because of #16451

@civibot
Copy link

civibot bot commented Mar 14, 2020

(Standard links)

@civibot civibot bot added the master label Mar 14, 2020
@colemanw
Copy link
Member

Change looks sensible & safe.

@colemanw colemanw merged commit 79c79f4 into civicrm:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants