dev/core#1714 Fix mis-filtering on activity type

[eileenmcnaughton]

Overview

This fixes a bug where the activity_type_id was being compared against the label of the option value

Before

Using Search Builder -
Choose Activity - Activity Type - = - Tell a Friend.
Actual results - 0
Choose Activity - Activity Type ID - = - Tell a Friend. (Not listed as a ID just the label)
Actual results - 92

After

Filter correctly filters

Technical Details

Most of the code in the handling for the first bunch of fields was silly. I added a test for each field to ensure they would be non-weird without it all

Comments

https://lab.civicrm.org/dev/core/-/issues/1714

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

I love how this deletes 40 lines of garbage and adds 60 lines of tests.

[eileenmcnaughton]

@demeritcowboy @kcristiano any chance one of you can do further UI testing on this - because it targets the rc. Note there are some weird things still happening but I think they pre-exist

[demeritcowboy]

I can do some tomorrow.

[kcristiano]

@eileenmcnaughton I id an r-run and it does solve the specific issue in https://lab.civicrm.org/dev/core/-/issues/1714

I also ran a number of other searches and could not find any issues. I would be more comfortable if we had more time, but I do think it is good to merge.

[colemanw]

@demeritcowboy I've merged this but your testing would still be helpful. Thanks for offering.

[demeritcowboy]

Agree with @kcristiano more time would be better but as noted there's a slew of existing weirdnesses so could spend forever on this. Activity Status appears twice in the dropdown, there's a chunk of E_NOTICEs when you edit the smart group, Find Activities has always been weird regarding target_contact, etc...

It does fix the stated problem. And adds some tests.

[eileenmcnaughton]

@demeritcowboy the double activity status thing is because @colemanw renamed the title on id fields to 'Activity Status' not 'Activity Status ID'. In the search code it actually uses the title for the id field and the option group title for the psuedofield