Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#1944) Add new columns to mailing summary report #18132

Merged
merged 1 commit into from Aug 12, 2020

Conversation

yashodha
Copy link
Contributor

Overview

Add new columns to mailing summary report

  • Sender name
  • Sender email

Before

No sender columns.

After

Sender name and email columns added.

@civibot
Copy link

civibot bot commented Aug 12, 2020

(Standard links)

@civibot civibot bot added the master label Aug 12, 2020
@demeritcowboy
Copy link
Contributor

demeritcowboy commented Aug 12, 2020

  • General standards
    • [r-explain] PASS
    • [r-user] PASS
    • [r-doc] PASS
    • [r-run] PASS
      • I don't know if it's been like this for a while, but I see the same on dmaster.demo so just mentioning it: The mailing report and also the find mailings screen seem to confuse "mailing name" and "subject". But it also lists an entry that has the right mailing name too.

Untitled

  • Developer standards
    • [r-tech] PASS
    • [r-code] PASS
    • [r-maint] ?
    • [r-test] PASS

@demeritcowboy
Copy link
Contributor

Ignore the name/subject comment. It only happens when using smtp setting redirect to database, which kind of makes sense since it makes fake mailing job entries which here duplicate the real mailing.

@colemanw colemanw merged commit 7770d50 into civicrm:master Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants