Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2141 - composer.json - Require league/oauth2-{client,google} #18908

Merged
merged 2 commits into from Nov 3, 2020

Conversation

totten
Copy link
Member

@totten totten commented Nov 2, 2020

Overview

This adds two libraries for https://lab.civicrm.org/dev/core/-/issues/2141.

Split out as a separate PR to reduce risk of merge-conflicts.

Note: This oauth2-client matches the constraint that's declared in civixero, which (in my
local copy of `universe`) is the only published extension that uses the same library.

The oauth2-google is included because has special requirements around
'prompt' which conflict with `GenericProvider`. We could potentially resolve that other
ways (eg rework `CiviGenericProvider`), but this seems easier right now.
@civibot
Copy link

civibot bot commented Nov 2, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

This has been discussed as part of the OAUTH work & these generally seem to be the leading libraries for this

@totten
Copy link
Member Author

totten commented Nov 2, 2020

Tangentially, to clarify little something -- note that league/oauth2-client has a GenericProvider that should work with many services. I've been using it with Microsoft's OAuth2 implementation and https://github.com/bshaffer/oauth2-demo-php.

There is at least one incompatibility between GenericProvider and Google's services. (I've only seen/investigated the one incompatibility. That specific one seems more the fault of GenericProvider IMHO, but fixing it upstream would likely require a BC-break.) So that's why I pulled in their supplemental package for Google.

@seamuslee001 seamuslee001 merged commit fef7e3f into civicrm:master Nov 3, 2020
@totten totten deleted the master-composer-oauth branch November 3, 2020 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants