dev/core#2864 Remove call to getTokenDetails from Contribute pdf letter #21805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On digging this is just a glorifed api call. The parameters loaded are only used in emailLetter for filtering
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#2864 Remove call to getTokenDetails from Contribute pdf letter
Before
A call is being done to render tokens that are not eventually used
After
apiv3 call
Technical Details
On digging this is just a glorifed api call. The parameters loaded are only used in emailLetter for filtering - since the values are not being used I didn't try to squeeze it into the rc
Comments
CRM_Contribute_Form_Task_PDFLetterCommonTest runs through this