Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop calling hook twice #22404

Merged
merged 1 commit into from Jan 7, 2022
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jan 7, 2022

Overview

Stop calling hook twice

Before

Relationship pre hook called twice on import & when creating current employer (and a JMA extension)

After

Only called once - per standard behaviour

Technical Details

Per the code comments this hook is called here but also in add. This is all about the crazy
history of this function - which used to be tied to the relationship form.

I can't think of any valid use for calling the hook twice - but I can think of reasons it
would be bad...

Comments

I added a note to the change log on this one https://lab.civicrm.org/documentation/docs/dev/-/blob/master/docs/hooks/changes.md

@civibot
Copy link

civibot bot commented Jan 7, 2022

(Standard links)

Per the code comments this hook is called here but also in add. This is all about the crazy
history of this function - which used to be tied to the relationship form.

I can't think of any valid use for calling the hook twice - but I can think of reasons it
would be bad...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants