Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

remove ".js" suffix so it doesn't broke under nginx #2589

Merged
merged 1 commit into from Mar 1, 2014

Conversation

Projects
None yet
2 participants
Contributor

tttp commented Mar 1, 2014

nginx is default config assumes *.js are static files, ie. it doesn't send it to php and goes directly on the file to try to send it. In this case, resulting on a 404 (obviously as it's not a file).

Contributor

tttp commented Mar 1, 2014

@colemanw I didn't understand your pro caching mod apache.

If the goal is to have an expiry date in the future, you can set it up in the header. Was it that?

colemanw added a commit that referenced this pull request Mar 1, 2014

Merge pull request #2589 from tttp/crm-14289
remove ".js" suffix so it doesn't broke under nginx

@colemanw colemanw merged commit f51d0f0 into civicrm:master Mar 1, 2014

Owner

colemanw commented Mar 1, 2014

Yes that was it. And we do set those in the header so it should be all good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment