From eea0a60fa9e0ba5d5d8b9f360cc27a4ef660c81c Mon Sep 17 00:00:00 2001 From: Coleman Watts Date: Wed, 21 Dec 2016 13:41:04 -0500 Subject: [PATCH] OptionValue Api cleanup - remove unnecessary lookup --- api/v3/OptionValue.php | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/api/v3/OptionValue.php b/api/v3/OptionValue.php index 2e5cd6d4a140..68cf4ad531ea 100644 --- a/api/v3/OptionValue.php +++ b/api/v3/OptionValue.php @@ -42,19 +42,21 @@ * API result array */ function civicrm_api3_option_value_get($params) { - - if (empty($params['option_group_id']) && !empty($params['option_group_name'])) { - $opt = array('version' => 3, 'name' => $params['option_group_name']); - $optionGroup = civicrm_api('OptionGroup', 'Get', $opt); - if (empty($optionGroup['id'])) { - return civicrm_api3_create_error("option group name does not correlate to a single option group"); - } - $params['option_group_id'] = $optionGroup['id']; - } - return _civicrm_api3_basic_get(_civicrm_api3_get_BAO(__FUNCTION__), $params); } +/** + * Adjust Metadata for get action. + * + * The metadata is used for setting defaults, documentation & validation. + * + * @param array $params + * Array of parameters determined by getfields. + */ +function _civicrm_api3_option_value_get_spec(&$params) { + $params['option_group_id']['api.aliases'] = array('option_group_name'); +} + /** * Add an OptionValue. *