Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Profile public title and misc contribution page improvements #279

Merged
merged 6 commits into from
Mar 24, 2018

Conversation

agh1
Copy link
Contributor

@agh1 agh1 commented Mar 23, 2018

No description provided.

@agh1
Copy link
Contributor Author

agh1 commented Mar 23, 2018

Towards #278

contribution page. You can also create new profiles.
If you want to collect information such as age, interests and skills that goes
beyond the essential fields required to make a contribution, you can include
existing [CiviCRM Profiles](/organising-your-data/profiles) at the beginning or
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agh1 can you put a .md on the end of the url as its an internal url

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the other URLs on the page have it--I thought I was told once not to do it. If the proper style is to include the .md I'm happy to fix all the links in the file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know. I'm sorry this is so confusing! It's explained here: https://docs.civicrm.org/dev/en/latest/documentation/markdown/#internal-url-standards

The .md isn't actually necessary, but adding it helps us avoid broken internal links. For links between guides, the URL should be treated as external and so you should grab the URL you see in the browser, which won't have a .md.

@agh1 agh1 changed the title [WIP] Profile public title and misc contribution page improvements Profile public title and misc contribution page improvements Mar 23, 2018
@agh1
Copy link
Contributor Author

agh1 commented Mar 23, 2018

Okay finished with work on this page. @seanmadsen thanks for the explanation on the .md, I just went through and changed them all on the page.

@seamuslee001
Copy link
Collaborator

I have reviewed these changes and they make sense. The screenshots are good. Merging

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants