Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jenkins to marketplace #12

Merged
merged 4 commits into from Oct 23, 2019
Merged

Add jenkins to marketplace #12

merged 4 commits into from Oct 23, 2019

Conversation

@ruanbekker
Copy link
Contributor

ruanbekker commented Oct 12, 2019

I used architecture as the category, as Im not too sure if there will be plans to use more categories as the time goes

ruanbekker added 2 commits Oct 12, 2019
```
$ kubectl exec -it jenkins-xxxxxxxxx-xxxxx -- cat /var/jenkins_home/secrets/initialAdminPassword
423d1248daee49b8949a73abe52b3a43
```

This comment has been minimized.

Copy link
@andyjeffries

andyjeffries Oct 12, 2019

Member

My only initial comment is, is it not possible to specify the initialAdminPassword from within a configmap or something or an ENV variable? Then we can randomly generate one using the CIVO:ALPHANUMERIC(x) value and have it presented in the Web UI and CLI? Like https://github.com/civo/kubernetes-marketplace/blob/master/postgresql/manifest.yaml#L29

This comment has been minimized.

Copy link
@ruanbekker

ruanbekker Oct 12, 2019

Author Contributor

Good point. Let me have a look into it.

@ruanbekker

This comment has been minimized.

Copy link
Contributor Author

ruanbekker commented Oct 13, 2019

Changed upstream to bitnami as the default jenkins image does not allow the change of their initial admin password.

Chose to go with bitnami rather than my own custom one, as bitnami closely tracks upstream source changes and promptly publishes new versions of this image using their automated systems.

jenkins/post_install.md Outdated Show resolved Hide resolved
@ruanbekker

This comment has been minimized.

Copy link
Contributor Author

ruanbekker commented Oct 22, 2019

  • tested persistence with longhorn and works as expected
  • added traefik ingress steps in post install
@andyjeffries andyjeffries merged commit 476f36f into civo:master Oct 23, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@andyjeffries

This comment has been minimized.

Copy link
Member

andyjeffries commented Oct 23, 2019

Merging this and will be live on the site soon. We'll keep it in Architecture for now, but it may move to a new tab soon.

@ruanbekker ruanbekker mentioned this pull request Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.