use the system RtAudio on Linux #436

Merged
merged 3 commits into from Feb 7, 2017

Projects

None yet

2 participants

@stefantalpalaru
Contributor

Tested on Gentoo ~amd64 with rtaudio-4.1.2 . It will use whatever backends were enabled in the system-wide RtAudio library, auto-detecting the required defines, includes and libraries thanks to pkg-config.

@stefantalpalaru stefantalpalaru use the system RtAudio on Linux 03eb22a
@cjcliffe
Owner
cjcliffe commented Sep 3, 2016

@stefantalpalaru this looks good; will try updating the flatpak and appimagekit builds to use it and merge if all works out.

@cjcliffe cjcliffe added the enhancement label Sep 3, 2016
@cjcliffe cjcliffe added this to the 0.2.x milestone Sep 3, 2016
@cjcliffe cjcliffe self-assigned this Sep 3, 2016
@stefantalpalaru stefantalpalaru Merge branch 'master' into rtaudio f4a60e6
@cjcliffe
Owner
cjcliffe commented Feb 6, 2017

Hey @stefantalpalaru -- if you can add a boolean build flag to the CMakeLists.txt to make system RtAudio optional and revert the built-in version and flags then I'll merge this in. It's likely to cause problems with Windows, OSX and users currently building from master as it is now. Thanks!

@stefantalpalaru stefantalpalaru add USE_SYSTEM_RTAUDIO flag, off by default d1686f9
@cjcliffe
Owner
cjcliffe commented Feb 7, 2017

@stefantalpalaru update looks good; will try it here soon and merge -- I like the idea of using a macro to group the dependencies -- I may use that to clean up some other platform-specific cmake logic.

Cheers!

@cjcliffe cjcliffe merged commit d1686f9 into cjcliffe:master Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment