Use snprintf() to make OpenBSD happy.

cjdelisle · Dec 10, 2012 · 0f3cd1c · 0f3cd1c
1 parent 8dc5d31
commit 0f3cd1c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/benc/serialization/json/JsonBencSerializer.c b/benc/serialization/json/JsonBencSerializer.c
@@ -75,10 +75,10 @@ static int32_t serializeString(const struct Writer* writer,
         chr = (uint8_t) string->bytes[i] & 0xFF;
         /* Nonprinting chars, \ and " are hex'd */
         if (chr < 126 && chr > 31 && chr != '\\' && chr != '"') {
-            sprintf(buffer, "%c", chr);
+            snprintf(buffer, 4, "%c", chr);
             writer->write(buffer, 1, writer);
         } else {
-            sprintf(buffer, "\\x%.2X", chr);
+            snprintf(buffer, 4, "\\x%.2X", chr);
             writer->write(buffer, 4, writer);
         }
     }

diff --git a/benc/serialization/standard/StandardBencSerializer.c b/benc/serialization/standard/StandardBencSerializer.c
@@ -41,11 +41,8 @@ static int32_t serializeGeneric(const struct Writer* writer,
 static int32_t writeint64_t(const struct Writer* writer,
                             int64_t integer)
 {
-    char buffer[32];
-    Bits_memset(buffer, 0, 32);
-
-    sprintf(buffer, "%" PRId64, integer);
-
+    char buffer[32] = {0};
+    snprintf(buffer, 32, "%" PRId64, integer);
     return writer->write(buffer, strlen(buffer), writer);
 }