Complete coverage: edge cases #3

Merged
merged 5 commits into from Jun 3, 2012

Conversation

Projects
None yet
2 participants
Contributor

kouno commented May 31, 2012

I would need feed back on this concerning the vocabulary used in the tests, and if the tests are well organized. Thanks.

kouno added some commits May 30, 2012

Add tests to reach 100% coverage.
Some edge cases have not been covered yet.
Add tests for Int and Real.
to_json was not actually implemented. (Integer and Float does not have any to_json functions)
Add tests and complete 100% coverage goal.
Basically add scenarios for corner cases:
- supertype usage with subtypes.
- keeping origin of identification inheritance.
- entity types which want to inherit from value type.
- relationship with naming mismatch.
Owner

cjheath commented Jun 2, 2012

Initial comments: Looking ok generally:

  • Thanks for fixing JSON, I'd just made a start there.
  • I think that deleting == will cause problems for callers so I put them back
  • The "role proxies" terminology is wrong - role proxies was an experiment that didn't work and has been removed.
  • It's not (yet) intended to be able to dynamically change supertypes - no harm testing it though.
  • activefacts has RSpec matchers using outdated APIs and I must fix it before I can be sure it works with this activefacts-api

I'm busy, it might take a couple of days...

Contributor

kouno commented Jun 2, 2012

Hum... My bad. For == it seems like I didn't place the necessary test cases there. I actually run into a problem when using JRuby. I will add it in later.

Add tests for ==().
The `==` function does not work as expected for JRuby. It's the
same as `hash` and `eql?`.
Owner

cjheath commented Jun 3, 2012

Ok, finally figured out how to fix the RSpec Matchers in activefacts so I can re-test it with this activefacts-api. Lots broken (due to wip) but nothing is down to activefacts-api, so I'm merging.

cjheath added a commit that referenced this pull request Jun 3, 2012

Merge pull request #3 from Kouno/complete-coverage
Complete coverage: edge cases

@cjheath cjheath merged commit df7f6f3 into cjheath:master Jun 3, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment