GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
I would need feed back on this concerning the vocabulary used in the tests, and if the tests are well organized. Thanks.
Add tests to reach 100% coverage.
Some edge cases have not been covered yet.
Fix spelling and missing require/copyright in numeric_spec.
Add tests for Int and Real.
to_json was not actually implemented. (Integer and Float does not have any to_json functions)
Add tests and complete 100% coverage goal.
Basically add scenarios for corner cases:
- supertype usage with subtypes.
- keeping origin of identification inheritance.
- entity types which want to inherit from value type.
- relationship with naming mismatch.
Initial comments: Looking ok generally:
I'm busy, it might take a couple of days...
Hum... My bad. For == it seems like I didn't place the necessary test cases there. I actually run into a problem when using JRuby. I will add it in later.
Add tests for ==().
The `==` function does not work as expected for JRuby. It's the
same as `hash` and `eql?`.
Ok, finally figured out how to fix the RSpec Matchers in activefacts so I can re-test it with this activefacts-api. Lots broken (due to wip) but nothing is down to activefacts-api, so I'm merging.
Merge pull request #3 from Kouno/complete-coverage
Complete coverage: edge cases