Skip to content

Commit

Permalink
assert: handle sparse arrays in deepStrictEqual
Browse files Browse the repository at this point in the history
Detect sparse array ends and add a fail early path for
unequal array length.

PR-URL: nodejs#15027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
  • Loading branch information
BridgeAR authored and cjihrig committed Aug 30, 2017
1 parent a1bb9c1 commit 9437c18
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
9 changes: 8 additions & 1 deletion lib/assert.js
Expand Up @@ -180,7 +180,14 @@ function strictDeepEqual(actual, expected) {
if (Object.getPrototypeOf(actual) !== Object.getPrototypeOf(expected)) {
return false;
}
if (isObjectOrArrayTag(actualTag)) {
if (actualTag === '[object Array]') {
// Check for sparse arrays and general fast path
if (actual.length !== expected.length)
return false;
// Skip testing the part below and continue in the callee function.
return;
}
if (actualTag === '[object Object]') {
// Skip testing the part below and continue in the callee function.
return;
}
Expand Down
3 changes: 3 additions & 0 deletions test/parallel/test-assert-deep.js
Expand Up @@ -466,4 +466,7 @@ assertOnlyDeepEqual(
assertDeepAndStrictEqual(m3, m4);
}

assertDeepAndStrictEqual([1, , , 3], [1, , , 3]);
assertOnlyDeepEqual([1, , , 3], [1, , , 3, , , ]);

/* eslint-enable */

0 comments on commit 9437c18

Please sign in to comment.