From 1b3dbc9635d45c83e355d312b6114d58664b1e7a Mon Sep 17 00:00:00 2001
From: zfx <502545703@qq.com>
Date: Tue, 18 Feb 2020 22:35:08 +0800
Subject: [PATCH] events: fix removeListener for Symbols

Fix removeListener when eventName type is 'symbol'.

```js
const EventEmitter = require('events');
const myEmitter = new EventEmitter();
const sym = Symbol('symbol');
const fn = () => { };
myEmitter.on(sym, fn);

myEmitter.on('removeListener', (...args) => {
  console.log('removeListener');
  console.log(args, args[0] === sym, args[1] === fn);
});

myEmitter.removeAllListeners()
```

When the listener's eventName type is 'symbol' and removeListener is
called with no parameters, removeListener should be emitted.

PR-URL: https://github.com/nodejs/node/pull/31847
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 lib/events.js                                       |  3 +--
 .../test-event-emitter-remove-all-listeners.js      | 13 +++++++++++++
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/lib/events.js b/lib/events.js
index 4a8311af059295..b138979e138fdf 100644
--- a/lib/events.js
+++ b/lib/events.js
@@ -31,7 +31,6 @@ const {
   ObjectDefineProperty,
   ObjectGetPrototypeOf,
   ObjectSetPrototypeOf,
-  ObjectKeys,
   Promise,
   PromiseReject,
   PromiseResolve,
@@ -526,7 +525,7 @@ EventEmitter.prototype.removeAllListeners =
 
       // Emit removeListener for all listeners on all events
       if (arguments.length === 0) {
-        for (const key of ObjectKeys(events)) {
+        for (const key of ReflectOwnKeys(events)) {
           if (key === 'removeListener') continue;
           this.removeAllListeners(key);
         }
diff --git a/test/parallel/test-event-emitter-remove-all-listeners.js b/test/parallel/test-event-emitter-remove-all-listeners.js
index 3dfe65a8b4bfd0..c62183fd08c203 100644
--- a/test/parallel/test-event-emitter-remove-all-listeners.js
+++ b/test/parallel/test-event-emitter-remove-all-listeners.js
@@ -108,3 +108,16 @@ function expect(expected) {
   ee._events = undefined;
   assert.strictEqual(ee, ee.removeAllListeners());
 }
+
+{
+  const ee = new events.EventEmitter();
+  const symbol = Symbol('symbol');
+  const noop = common.mustNotCall();
+  ee.on(symbol, noop);
+
+  ee.on('removeListener', common.mustCall((...args) => {
+    assert.deepStrictEqual(args, [symbol, noop]);
+  }));
+
+  ee.removeAllListeners();
+}