Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom allocator option #60

Merged
merged 1 commit into from Dec 1, 2019
Merged

add custom allocator option #60

merged 1 commit into from Dec 1, 2019

Conversation

@addaleax
Copy link
Collaborator

addaleax commented Dec 1, 2019

This is a good idea for libraries in general, and helps with tracking
memory allocated by uvwasi in Node.js.

The allocator struct format is identical to the one used by nghttp2
and related libraries, which makes things a bit easier because we’ve
added generic support for that format in the QUIC repo.

This is a good idea for libraries in general, and helps with tracking
memory allocated by uvwasi in Node.js.

The allocator struct format is identical to the one used by nghttp2
and related libraries, which makes things a bit easier because we’ve
added generic support for that format in the QUIC repo.
addaleax added a commit to addaleax/node that referenced this pull request Dec 1, 2019
@addaleax addaleax mentioned this pull request Dec 1, 2019
3 of 3 tasks complete
@cjihrig
cjihrig approved these changes Dec 1, 2019
Copy link
Owner

cjihrig left a comment

LGTM.

I think the answer is "yes" but double checking... does https://travis-ci.com/nodejs/node/jobs/261846786 include Node's wasi test suite?

@addaleax

This comment has been minimized.

Copy link
Collaborator Author

addaleax commented Dec 1, 2019

I think the answer is "yes" but double checking... does https://travis-ci.com/nodejs/node/jobs/261846786 include Node's wasi test suite?

@cjihrig Travis runs the default test suites, which includes wasi afaict, yes: https://github.com/nodejs/node/blob/6bf5a1d691291cdfcc4941e68f00d0003e565476/tools/test.py#L1487-L1506

@cjihrig

This comment has been minimized.

Copy link
Owner

cjihrig commented Dec 1, 2019

Cool. Thanks!

@cjihrig cjihrig merged commit aeee482 into cjihrig:master Dec 1, 2019
5 checks passed
5 checks passed
build (ubuntu-latest)
Details
build (ubuntu-latest)
Details
build (ubuntu-latest)
Details
build (windows-latest) build (windows-latest)
Details
build (macOS-latest)
Details
@addaleax addaleax deleted the addaleax:alloc branch Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.