Permalink
Switch branches/tags
Nothing to show
Commits on Sep 23, 2013
Commits on Sep 21, 2013
  1. HACK: Improve diffs between patch sets in a change.

    ckamm committed Aug 31, 2013
    By filtering out changes that are purely due to differences between
    the base commits. This has a big effect when patch sets were rebased.
    
    This is a hack because it makes some constructors public that used to
    be private and doesn't make the filtering optional somehow.
    It should be safe, however, as it prefers to not drop an edit when in
    doubt.
Commits on Sep 18, 2013
  1. Fix installation of plugins

    davido authored and David Ostrovsky committed Sep 6, 2013
    e51c428 broke the unregistering of plugin
    owned SSH command by passing wrong instance to the ConcurrentMap.remove()
    function.
    
    bae9e58 was trying to fix it, but broke it
    for the installation of plugins by throwing the `IllegalStateException` in case
    the old registration handle wasn't found. But it's perfectly possible and even
    wanted during plugin reloading: registration handle is replaced and the old one
    cannot be found.
    
    Moreover, bae9e58 didn't fix all places:
    the same bug in unregistering of SSH commands in
    DispatchCommandProvider.replace() method wasn't fixed.
    
    Change-Id: I21132d4f7aec58347acbf50d75a962cb8251201f
  2. Merge "NPE when deleting draft patch set when previous draft already …

    EdwinKempin authored and Gerrit Code Review committed Sep 18, 2013
    …deleted" into stable-2.6
  3. Remove documentation links from admin page

    dpursehouse committed Sep 18, 2013
    The links for Change-Id and Signed-off-by documentation in the
    admin page are hard-coded to specific versions on the the
    gerrit-documentation.googlesource.com site.
    
    This causes two problems.  Firstly, they are not links to local
    versions, and secondly it is easy to forget to update them and
    they become out of date.
    
    Remove the links.  Administrators should be capable of finding
    the relevant pages in the documentation by themselves.
    
    Bug: Issue 2127
    Change-Id: Idd4ddd1126e0631615d564173a02e3047aa87559
  4. NPE when deleting draft patch set when previous draft already deleted

    dpursehouse committed Sep 17, 2013
    If a change has 3 patch sets, all of which are drafts, and draft
    patch set 2 is deleted, attempting to delete draft patch set 3 (the
    current patch set) will result in NPE.
    
    The reason is that on deleting a draft patch set which is the current
    patch set, the current patch set is set to the previous patch set
    whose ID is calculated by subtracting 1 from the deleted patch set ID.
    
    This does not work if the previous patch set has already been deleted.
    
    Instead, set the current patch set to the highest patch set ID that
    is available.
    
    Bug: Issue 2128
    Change-Id: I235d4d943a5525e8223218a97f4702e26f09a69e
Commits on Sep 2, 2013
  1. Fix example for 'test-submit rule' in Prolog cookbook

    Edwin Kempin
    Edwin Kempin committed Sep 2, 2013
    Since commit b1f730b it is
    'test-submit rule' and not anymore 'test-submit-rule'.
    
    Change-Id: I4c32893afa1410af5347a8b659c5811aac218f63
    Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Commits on Aug 31, 2013
  1. Fix reenabling of plugins

    davido authored and spearce committed Aug 31, 2013
    e51c428 broke the unregistering of plugin
    owned SSH command by passing wrong instance to the ConcurrentMap.remove()
    function. Currently plugins can not be reenabled.
    
    Change-Id: I2b2dfe6ffe89a426a03d945d9695bc35e7fe9f1a
Commits on Aug 29, 2013
  1. Fix: RepoCommandLink's text is wrong

    BruceZu authored and dpursehouse committed Aug 29, 2013
    The title of the "repo download" link was mistakenly set to "checkout"
    during refactoring in commit cbc629f.
    
    Change it to the correct "repo download" title.
    
    Bug: Issue 2093
    Change-Id: I4c30d0fedf56942f741edbbfaa7505052e5e370c
Commits on Aug 19, 2013
  1. fix: NoOp score not displayed for open changes

    Pravin Sethia Pravin Sethia
    Pravin Sethia authored and Pravin Sethia committed Jul 29, 2013
    Score for NoBlock/NoOp category doesn't get displayed for open changes
    on All --> Open or My --> Changes. For such category, none of the label
    flags i.e. recommended, liked, approved or rejected flags are set for
    open changes.
    
    Further, abandoned and merged change display different images for same
    score e.g. If a -1 has been assigned, Abandoned change displays a "X"
    whereas a Merged change displays "-1". A Merged can be rejected for a
    NoBlock or NoOp category type.
    
    Bug: Issue 2056
    Change-Id: I29cfa02f4a43ef6be1cb94614ed75b979a84f7af
    (cherry picked from commit e88304a)
Commits on Aug 14, 2013
  1. Fix browser NPE when ChangeCache is incomplete

    spearce committed Aug 13, 2013
    The ChangeCache is buggy and does not always populate its
    contents. Unfortunately it is also designed to be unable to
    load missing contents on demand, causing consumers to NPE.
    ConfigInfoCache is a better design for this sort of lazy
    loading and reuse of data.
    
    ChangeCache can be missing information if:
    
      1) opens side-by-side view in a new tab;
      2) user presses 'r' to open publish comment screen
    
    Instead of using the unreliable ChangeCache, stub out a
    ChangeDetail to feed to the info block on the publish
    comments screen.
    
    Bug: issue 2039
    Change-Id: Id542528d93af1cab49b001ca5e90addfc5d05b78
    (cherry picked from commit f646aa7)
Commits on Aug 13, 2013
  1. Expand capabilities of ldap.groupMemberPattern

    Scott Dial
    Scott Dial committed Aug 11, 2013
    Previously, the pattern supported a limited set of variables that were
    either accidentially available (due to their use in other queries) or
    hard-coded (e.g., `username` is a special-case that was added).
    Furthermore, the documentation made reference to being able to use
    variables such as `${uidNumber}` even though they are not actually
    supported (since `uidNumber` is normally never queried). Under the
    default RFC 2307 configuration of LDAP, the only variables available
    were `displayName, `mail`, `uid`, and `username` (It's noteworthy
    that `username` was added as a special-case due to the default
    `groupMemberPattern` containing `${username}` even though `username`
    is substitued by Gerrit and not LDAP).
    
    This changeset removes the artificial restrictions on the attributes
    used in the `groupMemberPattern`. Any variable is assumed to
    originate from the account, but `username` is still overridden and
    provided by Gerrit (as before). This allows more expressive patterns,
    which allows us to fix an outstanding bug in group matching. Prevously,
    a user whose `gidNumber` matched the group's `gidNumber` would not have
    been included in the group. This changeset updates the default
    `groupMemberPattern` to account for this issue by adding the additional
    case of `(gidNumber=${gidNumber}`.
    
    Bug: Issue 2054
    Change-Id: Iff3a14c569a10c1ef693b672f4710fb6f2f8d9a6
Commits on Aug 12, 2013
  1. Fix Gerrit plugins under Tomcat by avoiding Guice static filter

    spearce committed Aug 9, 2013
    The static GuiceFilter breaks when a plugin loads and configures
    its own web environment. Follow the pattern used by JettyServer
    to initialize and load GuiceFilter in a non-static way, allowing
    Gerrit to always have its own filter stack during any request.
    
    Bug: issue 1966
    Change-Id: I864f3badc4ec90154a276d35e6a5a3fa75058933
Commits on Aug 6, 2013
  1. Say in gsql documentation that 'Access Database' capability is required

    Edwin Kempin
    Edwin Kempin committed Aug 6, 2013
    Since abd6d4e the 'Access Database'
    capability is required to run the gsql command.
    
    Change-Id: I39b2b22be975172839ab9808649afcfc58994806
    Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
Commits on Jul 16, 2013
  1. Release notes for Gerrit 2.6.2

    dpursehouse committed Jul 9, 2013
    Change-Id: I601b56793f265603d608bc397f386d35c0cdf3b8
Commits on Jul 15, 2013
  1. Fix NullPointerException when comparing AccessSections

    Edwin Kempin authored and dpursehouse committed Jun 18, 2013
    AccessSection.permissions and Permission.rules may not be set and null
    values should be handled in the equals methods.
    
    We saw this NPE when PermissionCollection tried to sort the access
    sections.
    
    Change-Id: I6f5a0886e6f9e5498fe9d756f289c5e91ed3485e
    Signed-off-by: Edwin Kempin <edwin.kempin@sap.com>
    (cherry picked from commit 915104d)
Commits on Jul 10, 2013
  1. Clarify that file:regex over is:watched never works

    davido committed Jul 10, 2013
    Change-Id: I5231ae2713954a453d9e311aaf03f5a055c6533f
Commits on Jul 6, 2013
  1. Merge "PrettyFormatter: Fix expand tab when syntax coloring is on." i…

    spearce authored and Gerrit Code Review committed Jul 6, 2013
    …nto stable-2.6
  2. Merge "Properly handle double click on external group in GroupTable" …

    spearce authored and Gerrit Code Review committed Jul 6, 2013
    …into stable-2.6
Commits on Jul 5, 2013
  1. Fix: NullPointerException of dashboard title

    BruceZu committed Jul 1, 2013
    Fixed according to the Document about dashboard.title: "If not specified
    the path of the dashboard config file is used as title."
    
    Change-Id: Ia55ed5e491c676d3c4bfea4a069b998817997e24
    (cherry picked from commit d4268bd)
Commits on Jul 4, 2013
  1. Properly handle double click on external group in GroupTable

    dluksza committed Jul 2, 2013
    Previously double click action on row with external group result in
    "Undefined group exception" because Gerrit trys to load internal group
    screen for this group. Now we will discover external groups and use
    external group URL (if provided) to forward user to external system same
    as we do on single click.
    
    Change-Id: I3636d6af306d5eebf48dc76ca66662271d378f10
    Signed-off-by: Dariusz Luksza <dariusz@luksza.org>
Commits on Jul 2, 2013
  1. Add plugin repositories section in the pom

    dpursehouse authored and orgads committed Apr 12, 2013
    Without this section in the pom, the Eclipse build of gerrit-gwtexpui fails:
    
    Project build error: Unresolveable build extension: Plugin com.googlesource.gerrit:gs-maven-
     wagon:3.3 or one of its dependencies could not be resolved: Failure to find
     com.googlesource.gerrit:gs-maven-wagon:jar:3.3 in http://repo.maven.apache.org/maven2
     was cached in the local repository, resolution will not be reattempted until the update interval
     of central has elapsed or updates are forced
    
    Change-Id: I0fa4b97ae653fbe757ebcfbbab153f22d87b07bb
    (cherry picked from commit 475fc60)
Commits on Jul 1, 2013
  1. PrettyFormatter: Fix expand tab when syntax coloring is on.

    afabre authored and spearce committed Jun 29, 2013
    prettify lost support for expanding tabs in r143 [1]. As a consequence,
    tab width preference is no longer honored.
    
    Gerrit now handles expanding tabs by itself in all cases, even if syntax
    coloring is active.
    
    [1] http://code.google.com/p/google-code-prettify/source/detail?r=143
    
    Bug: issue 1872
    Change-Id: I283a3620b1d130d3f66e56d3f202a5122d7a73b8
Commits on Jun 30, 2013
  1. PrettyFormatter: Fix ArrayIndexOutOfBoundException with CRLF files.

    afabre committed Jun 29, 2013
    Change I6d82ce322d401743a8de5ab8090b2adc43a909f5 added a workaround for
    a bug in prettify, by temporarily adding a space before each \n
    character.
    
    For files with CRLF line endings, this means replacing "\r\n" by
    "\r<space>\n", which prettify sees as two lines. This leads to a
    crash since Gerrit expects a consistent number of lines even after
    prettify.
    
    When Show Line Endings is active, the issue does not appear since \r
    are replaced with a specific markup, without any actual \r.
    
    Change-Id: I345e332225e449c6f26871476f1a07e67458da59
Commits on Jun 26, 2013
  1. Allow label values to be configured with no text

    dpursehouse committed Jun 26, 2013
    Internal Server Error is raised during Gerrit startup if a project
    is configured with a label that has a value with no text:
    
    [label My-Label]
      value = -1 Failed
      value = 0
      value = +1 Passed
    
    (Note that there is no text after "value = 0".)
    
    Internal Server Error is raised due to IndexOutOfBoundsException
    while constructing a LabelValue and assuming that the label has
    both a numeric value and a text value.
    
    Fix this by checking if there is a text value, and if there is no
    text value, defaulting to an empty string.
    
    Change-Id: Ib2f0532e64be745ba1ed83c372e804743a5afa7e
Commits on Jun 22, 2013
  1. Merge 'v2.5.5'

    spearce committed Jun 22, 2013
    * commit 'v2.5.5':
      Update JGit to patch security hole during clone
    
    Change-Id: I3d34b819a115d4fd6ddfe1011e9c2441085db82c
  2. Merge 'v2.4.3'

    spearce committed Jun 22, 2013
    * commit 'v2.4.3':
      Update JGit to patch security hole during clone
    
    Change-Id: I5a236e06384b7a1ba4c923f3219c04b6922a395d
  3. Merge 'v2.1.9^0'

    spearce committed Jun 22, 2013
    * commit 'v2.1.9':
      Update JGit to patch security hole during clone
    
    Change-Id: I7ee366b2f7f930da5f63dd5f173e47a33f280436
  4. Update JGit to patch security hole during clone

    spearce committed Jun 22, 2013
    Change-Id: I95de1ac7f97609f0fed05c9071c082c13d436d04
Commits on Jun 21, 2013
  1. Switch to gs-maven-wagon for API deployment

    spearce committed Jun 21, 2013
    Change-Id: I0a920ea71dcc886a263dc24fa8cc2ac19f3bbb99
  2. Gerrit 2.6

    spearce committed Jun 21, 2013
    Change-Id: I7b6704181bae0953d7de021611ff8e8a0165b93f
Commits on Jun 14, 2013
  1. Merge "Remove resizing search box and fix width at 70" into stable-2.6

    spearce authored and Gerrit Code Review committed Jun 14, 2013
  2. Remove resizing search box and fix width at 70

    spearce authored and StephenKing committed Apr 23, 2013
    Many Gerrit users have been complaining to me about the automatically
    resizing search box. They find the UI confusing and unwanted. Remove
    the resizing feature and fix the width at the full size, aka 70
    columns wide.
    
    Change-Id: I40b6d8060bc6c2258a00db177bff82f176edff39