From 1e8a1a2b7f7e4af85a85736f7d28030441df6694 Mon Sep 17 00:00:00 2001 From: Sean Hammond Date: Mon, 25 Feb 2013 13:51:56 +0100 Subject: [PATCH] [#445] Refactor a loop in multilingual plugin This just makes a small loop in ckanext/multilingual clearer, the logic should be the same. --- ckanext/multilingual/plugin.py | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/ckanext/multilingual/plugin.py b/ckanext/multilingual/plugin.py index a6d0b48a3a8..a554042f209 100644 --- a/ckanext/multilingual/plugin.py +++ b/ckanext/multilingual/plugin.py @@ -124,14 +124,11 @@ def before_index(self, search_data): for key, value in search_data.iteritems(): if key in KEYS_TO_IGNORE or key.startswith('title'): continue - if isinstance(value, list): - for item in value: - if isinstance(item, basestring): - all_terms.append(item) - elif not isinstance(value, basestring): - continue - else: - all_terms.append(value) + if not isinstance(value, list): + value = [value] + for item in value: + if isinstance(item, basestring): + all_terms.append(item) field_translations = action_get.term_translation_show( {'model': ckan.model},