From 35c2184dd525a89135f3bd905c72f1ae68f27089 Mon Sep 17 00:00:00 2001 From: kindly Date: Tue, 12 Nov 2013 09:58:37 +0000 Subject: [PATCH] [#1251] add resource view back in data_dict sent to all templates --- ckan/controllers/package.py | 3 ++- ckan/lib/helpers.py | 2 +- ckan/templates/package/snippets/resource_view.html | 14 +++++++------- ckanext/reclinepreview/plugin.py | 2 +- 4 files changed, 11 insertions(+), 10 deletions(-) diff --git a/ckan/controllers/package.py b/ckan/controllers/package.py index bebc0b4d6b4..0c82318194e 100644 --- a/ckan/controllers/package.py +++ b/ckan/controllers/package.py @@ -1504,13 +1504,14 @@ def edit_view(self, id, resource_id, view_id=None): package_type=package_type) data_dict = {'package': c.pkg_dict, 'resource': c.resource, - 'data': data} + 'resource_view': data} view_template = view_plugin.view_template(context, data_dict) form_template = view_plugin.form_template(context, data_dict) vars = {'form_template': form_template, 'view_template': view_template, + 'data': data, 'errors': errors, 'error_summary': error_summary, 'to_preview': to_preview} diff --git a/ckan/lib/helpers.py b/ckan/lib/helpers.py index 42bb9965877..aa13d2c534a 100644 --- a/ckan/lib/helpers.py +++ b/ckan/lib/helpers.py @@ -1633,7 +1633,7 @@ def rendered_resource_view(resource_view, resource, package, embed=False): ''' view_plugin = datapreview.get_view_plugin(resource_view['view_type']) context = {} - data_dict = {'data': resource_view, + data_dict = {'resource_view': resource_view, 'resource': resource, 'package': package} vars = view_plugin.setup_template_variables(context, data_dict) or {} diff --git a/ckan/templates/package/snippets/resource_view.html b/ckan/templates/package/snippets/resource_view.html index e9366fd4912..ef373cac00a 100644 --- a/ckan/templates/package/snippets/resource_view.html +++ b/ckan/templates/package/snippets/resource_view.html @@ -1,9 +1,9 @@ -

{{data['title']}}

-
{{data['description']}}
+

{{resource_view['title']}}

+
{{resource_view['description']}}
- {% if not h.resource_view_is_iframed(data) %} - {{ h.rendered_resource_view(data, resource, package) }} + {% if not h.resource_view_is_iframed(resource_view) %} + {{ h.rendered_resource_view(resource_view, resource, package) }} {% else %}

@@ -21,12 +21,12 @@

{{data['title']}}

- {% if data.get('id') %} - {% set src = h.url(controller='package', action='resource_view', id=package['name'], resource_id=resource['id'], view_id=data['id']) %} + {% if resource_view.get('id') %} + {% set src = h.url(controller='package', action='resource_view', id=package['name'], resource_id=resource['id'], view_id=resource_view['id']) %} {% else %} {# When creating a new view no view_id exists, but we still want to preview it, so we stick the whole resource_view as a param as there is no other way to pass to information on to the iframe #} - {% set src = h.url(controller='package', action='resource_view', id=package['name'], resource_id=resource['id']) + '?' + h.urlencode({'resource_view': h.dump_json(data)}) %} + {% set src = h.url(controller='package', action='resource_view', id=package['name'], resource_id=resource['id']) + '?' + h.urlencode({'resource_view': h.dump_json(resource_view)}) %} {% endif %}