From 52005cb098848ffe55117fb46c06be1a96e59c5d Mon Sep 17 00:00:00 2001
From: Sean Hammond <seanhammond@lavabit.com>
Date: Wed, 3 Apr 2013 14:10:19 +0200
Subject: [PATCH] [#730] Only show 'Popular' sort option if tracking enabled

Sorting datasets by popularity only works if page view tracking is
enabled, so don't show the 'Popular' option in the 'Order by:' dropdown
if tracking isn't enabled.
---
 ckan/templates/snippets/sort_by.html | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ckan/templates/snippets/sort_by.html b/ckan/templates/snippets/sort_by.html
index a2a6076c3bc..fcc58fc74aa 100644
--- a/ckan/templates/snippets/sort_by.html
+++ b/ckan/templates/snippets/sort_by.html
@@ -15,7 +15,9 @@
     <option value="title_string asc"{% if sort=='title_string asc' %} selected="selected"{% endif %}>{{ _('Name Ascending') }}</option>
     <option value="title_string desc"{% if sort=='title_string desc' %} selected="selected"{% endif %}>{{ _('Name Descending') }}</option>
     <option value="metadata_modified desc"{% if sort=='metadata_modified desc' %} selected="selected"{% endif %}>{{ _('Last Modified') }}</option>
-    <option value="views_recent desc"{% if sort=='views_recent desc' %} selected="selected"{% endif %}>{{ _('Popular') }}</option>
+    {% if g.tracking_enabled %}
+      <option value="views_recent desc"{% if sort=='views_recent desc' %} selected="selected"{% endif %}>{{ _('Popular') }}</option>
+    {% endif %}
   </select>
   <button class="btn js-hide" type="submit">{{ _('Go') }}</button>
 </span>