From 54e8722bdb38ba66e9566c09c44c25edeb29aa07 Mon Sep 17 00:00:00 2001 From: Ian Murray Date: Fri, 29 Jun 2012 12:28:52 +0100 Subject: [PATCH] [#2439] Sanitise method parameters. And comment reason for making the list copy. Response to feedback from code-review. --- ckan/lib/search/query.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ckan/lib/search/query.py b/ckan/lib/search/query.py index feef9622ec1..39233423aeb 100644 --- a/ckan/lib/search/query.py +++ b/ckan/lib/search/query.py @@ -150,7 +150,10 @@ def run(self, query=None, terms=[], fields={}, facet_by=[], options=None, **kwar class TagSearchQuery(SearchQuery): """Search for tags.""" - def run(self, query=[], fields={}, options=None, **kwargs): + def run(self, query=None, fields=None, options=None, **kwargs): + query = [] if query is None else query + fields = {} if fields is None else fields + if options is None: options = QueryOptions(**kwargs) else: @@ -159,7 +162,7 @@ def run(self, query=[], fields={}, options=None, **kwargs): if isinstance(query, basestring): query = [query] - query = query[:] + query = query[:] # don't alter caller's query list. for field, value in fields.items(): if field in ('tag', 'tags'): query.append(value)